Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no support for StorageServiceMBean.getRangeToEndpointMap #36

Closed
slivne opened this issue Dec 20, 2016 · 6 comments · Fixed by #143
Closed

no support for StorageServiceMBean.getRangeToEndpointMap #36

slivne opened this issue Dec 20, 2016 · 6 comments · Fixed by #143
Assignees
@amnonh

Comments

@slivne
Copy link
Contributor

slivne commented Dec 20, 2016

We are missing support for this method

Some third party rely on it such as cassandra-reaper
@austinhallock
Copy link

Can confirm. https://github.com/scylladb/scylla/wiki/3rd-party-utilities should probably be updated to have cassandra-reaper under 'known to not work' instead of 'should work'. It starts up, but isn't able to run repairs without support for getRangeToEndpointMap

@penberg
Copy link
Contributor

penberg commented Jan 5, 2018

@austinhallock Thanks for testing. I update the wiki page. /cc @tzach

@tfendt
Copy link

tfendt commented Jun 19, 2018

Any update on this? We are looking to transition from cassandra to scylla and currently use reaper for automated repairs on keyspaces.

@tomer-sandler
Copy link

@tfendt Scylla has automated repairs via Scylla Manager (part of the enterprise version).
You can also set a chron job to trigger it every X days...

@dorlaor
Copy link

dorlaor commented Jul 8, 2019

@amnonh folks who use Janus Graph needs it and they rather not use Scylla Manager, how hard would it be to fix it?

@rmb938
Copy link

rmb938 commented Oct 2, 2020 •
edited
Loading

I am also having an issue since some jmx api's aren't supported and cassandra reaper can't function.

Scylla Manager isn't an option for my deployments since my clusters are more than 5 nodes.

@rmb938 rmb938 mentioned this issue Oct 2, 2020
Closed
amnonh added a commit to amnonh/scylla that referenced this issue Oct 5, 2020
@amnonh
api/storage_service.cc: Add the get_range_to_endpoint_map
5d508ca 
The get_range_to_endpoint_map method, takes a keyspace and returns a map
between the token ranges and the endpoint.

It is used by some external tools for repair.

Token ranges are codes as size-2 array, if start or end are empty, they will be
added as an empty string.

The implementation uses get_range_to_address_map and re-pack it
accordingly.

The use of stream_range_as_array it to reduce the risk of large
allocations and stalls.

Relates to scylladb/scylla-jmx#36

Signed-off-by: Amnon Heiman <[email protected]>
@amnonh amnonh mentioned this issue Oct 5, 2020
Closed
amnonh added a commit to amnonh/scylla-jmx that referenced this issue Oct 5, 2020
@amnonh
StorageService.java: Use the endpoint for getRangeToEndpointMap
293bc69 
After implementing range_to_endpoint_map endpoint update the API call to
it.

Fixes scylladb#36

Signed-off-by: Amnon Heiman <[email protected]>
@amnonh amnonh mentioned this issue Oct 5, 2020
Merged
penberg pushed a commit that referenced this issue Oct 8, 2020
@amnonh @penberg
StorageService.java: Use the endpoint for getRangeToEndpointMap
c51906e 
After implementing range_to_endpoint_map endpoint update the API call to
it.

Fixes #36

Signed-off-by: Amnon Heiman <[email protected]>
penberg pushed a commit to scylladb/scylladb that referenced this issue Oct 8, 2020
@amnonh @penberg
api/storage_service.cc: Add the get_range_to_endpoint_map
48c3c94 
The get_range_to_endpoint_map method, takes a keyspace and returns a map
between the token ranges and the endpoint.

It is used by some external tools for repair.

Token ranges are codes as size-2 array, if start or end are empty, they will be
added as an empty string.

The implementation uses get_range_to_address_map and re-pack it
accordingly.

The use of stream_range_as_array it to reduce the risk of large
allocations and stalls.

Relates to scylladb/scylla-jmx#36

Signed-off-by: Amnon Heiman <[email protected]>

Closes #7329
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amnonh amnonh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

StorageService.java: Use the endpoint for getRangeToEndpointMap amnonh/scylla-jmx
8 participants
@penberg @rmb938 @austinhallock @dorlaor @amnonh @slivne @tfendt @tomer-sandler