-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improvement(latency_calculator): allow use it in longevity tests #9628
improvement(latency_calculator): allow use it in longevity tests #9628
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
`latency_calculator_decorator` requires workload to be set. Up to now it was taken from the test name. This change allows to set it by `workload_name` test parameter, so it can be used in all kind of tests. Added latency verification for all 'individual nemesis' cases (proposal, anyway need to test with something). closes: scylladb#9627
7de539a
to
1c62e8d
Compare
@soyacz was just testing, to see we can collect metric into argus also in longevity, as needed. we are not gonna collect all metric from all longevity (at least not now) |
Yes, I tried it only, decision to add to all longevities is separate one. I think we could consider it individual nemesis cases - we could see the trends and possibly find regressions with it. But requires more effort as latencies are above 10ms causing test to fail, so we would need to make more decisions (whether increase error thresholds or reduce load/throttle it). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
latency_calculator_decorator
requires workload to be set. Up to now it was taken from the test name. This change allows to set it byworkload_name
test parameter, so it can be used in all kind of tests.Added latency verification for all 'individual nemesis' cases (proposal, anyway need to test with something).
closes: #9627
Testing
PR pre-checks (self review)
backport
labelsReminders
sdcm/sct_config.py
)unit-test/
folder)