Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improvement(node_exporter): upgrade to v1.8.2, remove unneeded collectors #9621

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

improvement(node_exporter): upgrade to v1.8.2, remove unneeded collectors #9621

wants to merge 1 commit into from
+2 −2

Conversation

mykaul
Copy link
Contributor

@mykaul mykaul commented Dec 26, 2024

This PR update node_exporter to v1.8.2 (just like Scylla) and removes the unneeded collectors that are enabled by default (just like Scylla). The only exception is interrupts - which are still enabled by default by Scylla and are not needed here.

Testing

  • NOT tested.

PR pre-checks (self review)

  • I added the relevant backport labels
  • I didn't leave commented-out/debugging code

@mykaul mykaul added the backport/none Backport is not required label Dec 26, 2024
@mykaul
Copy link
Contributor Author

mykaul commented Dec 26, 2024

Unsure why CI failed:
image

@soyacz
Copy link
Contributor

soyacz commented Dec 27, 2024

it failed on precommit (visible in GH checks), more specifically commit lint. We follow a structured tilte: <feature | fix | improvement>(<area>): <message> and commit message must be long enough.

@mykaul
Copy link
Contributor Author

mykaul commented Dec 29, 2024

it failed on precommit (visible in GH checks), more specifically commit lint. We follow a structured tilte: <feature | fix | improvement>(<area>): <message> and commit message must be long enough.

It's not mentioned @ https://github.com/scylladb/scylla-cluster-tests?tab=readme-ov-file#contribution-instructions , but I'll fix...

@mykaul mykaul changed the title node_exporter: upgrade to v1.8.2, remove unneeded collectors improvement(node_exporter): upgrade to v1.8.2, remove unneeded collectors Dec 29, 2024
@soyacz
Copy link
Contributor

soyacz commented Dec 30, 2024

Still failing on precommit due body's lines must not be longer than 120 characters [body-max-line-length]
best to install pre-commit hooks that will validate locally so no need to wait for CI.

@fruch fruch added the test-provision-aws Run provision test on AWS label Dec 30, 2024
@mykaul @fruch
improvement(node_exporter): upgrade to v1.8.2, remove unneeded collec…
f964252 
…tors

This PR updates node_exporter to v1.8.2 (just like Scylla).
In addition and unrelated to the version update, it removes
the unneeded collectors that are enabled by default (just like Scylla).
The only execption is interrupts - which are still enabled by
default by Scylla and are not needed here.

No functional changes are expected.

Signed-off-by: Yaniv Kaul <[email protected]>
@fruch fruch removed the test-provision-aws Run provision test on AWS label Jan 7, 2025
@fruch
Copy link
Contributor

fruch commented Jan 7, 2025 •
edited
Loading

I've fixed the commit message, waiting for AWS provision test

fruch

This comment was marked as outdated.

Sign in to view

@fruch fruch added the test-provision-aws Run provision test on AWS label Jan 7, 2025
fruch
fruch requested changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@fruch fruch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

waiting for provision test to pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fruch fruch fruch requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@mykaul mykaul

Labels
backport/none Backport is not required test-provision-aws Run provision test on AWS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mykaul @soyacz @fruch