Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Argus results for perf_simple_qurey regression validation #9578

Closed
soyacz opened this issue Dec 18, 2024 · 0 comments · Fixed by #9687
Closed

Use Argus results for perf_simple_qurey regression validation #9578

soyacz opened this issue Dec 18, 2024 · 0 comments · Fixed by #9687
Assignees
@soyacz

Comments

@soyacz
Copy link
Contributor

soyacz commented Dec 18, 2024

We use elasticsearch, last 10 results to verify regressions in perf microbenchmark tests.
Argus has already enough data and is able to do comparisons based on best results - let's switch to that.
@fruch fruch changed the title Use Argus results for microbenchmark regression validation Use Argus results for perf_simple_qurey regression validation Dec 22, 2024
soyacz added a commit to soyacz/scylla-cluster-tests that referenced this issue Jan 7, 2025
@soyacz
improvement(perf_simple_query): add validation rules for Argus
8c2ad10 
When sending perf_simple_query benchmark results, Argus will validate
numbers based on all history (submitted to Argus). Current approach
validates only 10 last results.

closes: scylladb#9578
@soyacz soyacz mentioned this issue Jan 7, 2025
Merged
3 tasks
soyacz added a commit to soyacz/scylla-cluster-tests that referenced this issue Jan 7, 2025
@soyacz
improvement(perf_simple_query): add validation rules for Argus
112a581 
When sending perf_simple_query benchmark results, Argus will validate
numbers based on all history (submitted to Argus). Current approach
validates only 10 last results.

closes: scylladb#9578
soyacz added a commit to soyacz/scylla-cluster-tests that referenced this issue Jan 7, 2025
@soyacz
improvement(perf_simple_query): add validation rules for Argus
ee0cb46 
When sending perf_simple_query benchmark results, Argus will validate
numbers based on all history (submitted to Argus). Current approach
validates only 10 last results.

closes: scylladb#9578
fruch pushed a commit that referenced this issue Jan 11, 2025
@soyacz @fruch
improvement(perf_simple_query): add validation rules for Argus
5fe7ebd 
When sending perf_simple_query benchmark results, Argus will validate
numbers based on all history (submitted to Argus). Current approach
validates only 10 last results.

closes: #9578
scylladbbot pushed a commit to scylladbbot/scylla-cluster-tests that referenced this issue Jan 11, 2025
@soyacz @actions-user
improvement(perf_simple_query): add validation rules for Argus
7cad077 
When sending perf_simple_query benchmark results, Argus will validate
numbers based on all history (submitted to Argus). Current approach
validates only 10 last results.

closes: scylladb#9578
(cherry picked from commit 5fe7ebd)
@scylladbbot scylladbbot mentioned this issue Jan 11, 2025
Closed
3 tasks
mergify bot pushed a commit that referenced this issue Jan 11, 2025
@soyacz @mergify
improvement(perf_simple_query): add validation rules for Argus
053df25 
When sending perf_simple_query benchmark results, Argus will validate
numbers based on all history (submitted to Argus). Current approach
validates only 10 last results.

closes: #9578
(cherry picked from commit 5fe7ebd)
mergify bot pushed a commit that referenced this issue Jan 11, 2025
@soyacz @mergify
improvement(perf_simple_query): add validation rules for Argus
a48956a 
When sending perf_simple_query benchmark results, Argus will validate
numbers based on all history (submitted to Argus). Current approach
validates only 10 last results.

closes: #9578
(cherry picked from commit 5fe7ebd)
This was referenced Jan 11, 2025
Merged
Merged
scylladbbot pushed a commit to scylladbbot/scylla-cluster-tests that referenced this issue Jan 11, 2025
@soyacz @actions-user
improvement(perf_simple_query): add validation rules for Argus
674199f 
When sending perf_simple_query benchmark results, Argus will validate
numbers based on all history (submitted to Argus). Current approach
validates only 10 last results.

closes: scylladb#9578
(cherry picked from commit 5fe7ebd)
@scylladbbot scylladbbot mentioned this issue Jan 11, 2025
Closed
3 tasks
fruch pushed a commit that referenced this issue Jan 12, 2025
@soyacz @fruch
improvement(perf_simple_query): add validation rules for Argus
22eb515 
When sending perf_simple_query benchmark results, Argus will validate
numbers based on all history (submitted to Argus). Current approach
validates only 10 last results.

closes: #9578
(cherry picked from commit 5fe7ebd)
fruch pushed a commit that referenced this issue Jan 12, 2025
@soyacz @fruch
improvement(perf_simple_query): add validation rules for Argus
2ad3750 
When sending perf_simple_query benchmark results, Argus will validate
numbers based on all history (submitted to Argus). Current approach
validates only 10 last results.

closes: #9578
(cherry picked from commit 5fe7ebd)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@soyacz soyacz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

improvement(perf_simple_query): add validation rules for Argus soyacz/scylla-cluster-tests
1 participant
@soyacz