Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin down urllib3<2 since botocore doesn't support it #453

Merged
merged 1 commit into from
May 10, 2023
Merged

pin down urllib3<2 since botocore doesn't support it #453

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/integration-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ jobs:

pip install -U pip setuptools

python setup.py install
pip install .
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how is this change related to the urllib3 problem?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought it was the issue at first.

Since there was a ton of new warning that setup.py install is going to be deprecated.

I might move it to it's own commit


if [ -f requirements-test.txt ]; then pip install -r requirements-test.txt; fi

Expand Down
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
url='https://github.com/pcmanus/ccm',
packages=['ccmlib', 'ccmlib.cmds', 'ccmlib.utils'],
scripts=[ccmscript],
install_requires=['pyYaml', 'psutil', 'requests', 'packaging', 'boto3', 'tqdm'],
install_requires=['pyYaml', 'psutil', 'requests', 'packaging', 'boto3', 'tqdm', 'urllib3<2'],
tests_require=['pytest'],
classifiers=[
"License :: OSI Approved :: Apache Software License",
Expand Down