Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugins/sct): Fix serialization of ResourceState enum #584

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

k0machi
Copy link
Collaborator

@k0machi k0machi commented Jan 28, 2025

The default value of state field was not being serialized properly due
to cqlengine being unable to handle Enum classes, fixed by getting the
Enum value in the default handler. This fixes an issue where SCT runner
would not be set with a vague "SyntaxException" error due to not
providing ResourceState.

The default value of state field was not being serialized properly due
to cqlengine being unable to handle Enum classes, fixed by getting the
Enum value in the default handler. This fixes an issue where SCT runner
would not be set with a vague "SyntaxException" error due to not
providing ResourceState.
@k0machi k0machi self-assigned this Jan 28, 2025
@k0machi k0machi requested review from fruch and soyacz January 28, 2025 12:35
Copy link
Contributor

@fruch fruch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@soyacz soyacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@k0machi k0machi merged commit d467316 into scylladb:master Jan 28, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants