fix(stats.py): Correctly collect worst-case status for tests #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes an issue where worst case collection function would never take the branch to compare statuses, leading to last status always being chosen - for 3 runs of (failed, pass, pass) the outcome would be pass and for (failed, pass, failed) it would be failed. This commit corrects this and now statuses are properly evaluated. Fixes scylladb#488
|
Before:
After:
|
fruch
reviewed
Nov 21, 2024
| if cmp_class(container_class(status)) < cmp_class(container_class(run[field_name])): | ||
| status_map[run_number] = run[field_name] | ||
| case (str(), dict()): | ||
| last_status, _ = status |
There was a problem hiding this comment.
has the content of status_map changed ? or this logic was never correct ?
I would recommend writing a unittest to guard this one
There was a problem hiding this comment.
I changed the logic at some point to support investigation statuses, but never updated the comparer matcher, so yes, it was never correct after that change, just happened to work sometimes.
soyacz
approved these changes
Nov 21, 2024
fruch
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes an issue where worst case collection function would
never take the branch to compare statuses, leading to last status always
being chosen - for 3 runs of (failed, pass, pass) the outcome would be
pass and for (failed, pass, failed) it would be failed. This commit
corrects this and now statuses are properly evaluated.
Fixes #488