-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add speed up demonstration of datashader #109
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Thanks for the PR, this is very informative! Just a few minor comments:
Thanks a lot! |
|
We actually already seem to have that. Will try to remove the HTML logic |
64b8551
to
1084ae9
Compare
for more information, see https://pre-commit.ci
…otebooks into speedup_datashader
@Sonja-Stockhaus @LucaMarconato I fixed some things that were causing warnings in other notebooks. Apparently, this fixed it. |
@Sonja-Stockhaus I modified your notebook slightly to have less redundant code. For testing I reduced the number of points. Will rerun over-night with enough However, for merging I'd wait until your main PR is merged because I want these to be real version accessible from PyPi. |
for more information, see https://pre-commit.ci
@timtreis ready to merge?? |
Not yet. On the one hand is datashader not faster for points, so that's weird. And then I wanted to first release sonjas feature branch so that the watermark has an actual release version attached and not a GitHub commit |
for more information, see https://pre-commit.ci
Little benchmark to demonstrate in which cases it is helpful to use datashader to increase rendering speed