-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Harmonize min-deps script with scanpy #1758
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks the same as before, no? The names just changed?
No, the logic of the The effect is that |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1758 +/- ##
==========================================
- Coverage 87.01% 84.51% -2.50%
==========================================
Files 40 40
Lines 6059 6059
==========================================
- Hits 5272 5121 -151
- Misses 787 938 +151
|
filter_specs = [ | ||
spec for spec in req.specifier if spec.operator in {"==", "~=", ">=", ">"} | ||
] | ||
if not filter_specs: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess what I was saying was that this condition looks identical but renamed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah you’re right! Apprently
- I already did that in Format sparse_dataset code #1524, then
- I didn’t port it to scanpy, then
- I fixed it independently in scanpy, finally
- I blindly “backported” the changes to here by just copying scanpy’s version over
I renamed the PR to match
…anpy) (#1776) Co-authored-by: Philipp A <[email protected]>
Before this PR, a dependency that only had
!=
constraints broke the script