Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harmonize min-deps script with scanpy #1758

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Harmonize min-deps script with scanpy #1758

merged 1 commit into from
Nov 22, 2024

Conversation

flying-sheep
Copy link
Member

@flying-sheep flying-sheep commented Nov 12, 2024

Before this PR, a dependency that only had != constraints broke the script

Copy link
Contributor

@ilan-gold ilan-gold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks the same as before, no? The names just changed?

@flying-sheep
Copy link
Member Author

flying-sheep commented Nov 12, 2024

No, the logic of the if statement is different. Before it checked if there were no conditions, now it checks if there are no conditions that we handle below.

The effect is that patsy!=1.0.0 now gets transformed into patsy instead of patsy==0.0.0.a1.* or so

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.51%. Comparing base (9f32361) to head (c9a7257).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1758      +/-   ##
==========================================
- Coverage   87.01%   84.51%   -2.50%     
==========================================
  Files          40       40              
  Lines        6059     6059              
==========================================
- Hits         5272     5121     -151     
- Misses        787      938     +151     

see 8 files with indirect coverage changes

---- 🚨 Try these New Features:

@ilan-gold ilan-gold modified the milestones: 0.11.1, 0.11.2 Nov 12, 2024
Comment on lines +43 to +46
filter_specs = [
spec for spec in req.specifier if spec.operator in {"==", "~=", ">=", ">"}
]
if not filter_specs:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess what I was saying was that this condition looks identical but renamed

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah you’re right! Apprently

  1. I already did that in Format sparse_dataset code #1524, then
  2. I didn’t port it to scanpy, then
  3. I fixed it independently in scanpy, finally
  4. I blindly “backported” the changes to here by just copying scanpy’s version over

I renamed the PR to match

@flying-sheep flying-sheep changed the title Handle != in min-deps script Harmonize min-deps script with scanpy Nov 22, 2024
@flying-sheep flying-sheep merged commit 997fbd7 into main Nov 22, 2024
19 of 23 checks passed
@flying-sheep flying-sheep deleted the fix-min-deps branch November 22, 2024 14:33
meeseeksmachine pushed a commit to meeseeksmachine/anndata that referenced this pull request Nov 22, 2024
flying-sheep added a commit that referenced this pull request Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants