Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep .X when setting filename to None #1724

Merged
merged 5 commits into from
Dec 9, 2024

Conversation

eroell
Copy link
Contributor

@eroell eroell commented Oct 21, 2024

Does _to_memory_mode only get called by the filename setter anyways? And are there reasons to not just call to_memory from this setter?

If not worth to go in depths here anymore, the removed _ would fix a bug for now I guess

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.52%. Comparing base (ea997d0) to head (a191287).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1724   +/-   ##
=======================================
  Coverage   84.52%   84.52%           
=======================================
  Files          40       40           
  Lines        6075     6075           
=======================================
  Hits         5135     5135           
  Misses        940      940           
Files with missing lines Coverage Δ
src/anndata/_core/file_backing.py 91.07% <100.00%> (ø)

@ilan-gold
Copy link
Contributor

@eroell Please add a test to check the behavior is correct of this so we can verify the fix actually works

@eroell
Copy link
Contributor Author

eroell commented Nov 13, 2024

Added a minimal check to verify this behaviour

@eroell
Copy link
Contributor Author

eroell commented Nov 20, 2024

added, @ilan-gold

@ilan-gold ilan-gold added this to the 0.11.2 milestone Dec 9, 2024
@ilan-gold ilan-gold enabled auto-merge (squash) December 9, 2024 14:20
@ilan-gold ilan-gold merged commit 1bd1f71 into scverse:main Dec 9, 2024
16 of 19 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/anndata that referenced this pull request Dec 9, 2024
ilan-gold pushed a commit that referenced this pull request Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.X is lost when setting anndata.filename to None
2 participants