Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix benchmarks and pandas compat #1100

Merged
merged 9 commits into from
Aug 21, 2023
Merged

Fix benchmarks and pandas compat #1100

merged 9 commits into from
Aug 21, 2023

Conversation

flying-sheep
Copy link
Member

@flying-sheep flying-sheep commented Aug 21, 2023

  • ASV 0.6.0 has some changes that make it loudly complain when mamba isn’t installed, so we might just as well switch to mamba. Side effect: Runs in 1 1/2 min instead of 5 1/2 min
  • pandas will fix their bug in the next RC, so let’s just skip this one

@flying-sheep flying-sheep added this to the 0.9.3 milestone Aug 21, 2023
@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Merging #1100 (28e0a88) into main (79e144f) will decrease coverage by 2.13%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1100      +/-   ##
==========================================
- Coverage   84.79%   82.67%   -2.13%     
==========================================
  Files          35       35              
  Lines        5090     5090              
==========================================
- Hits         4316     4208     -108     
- Misses        774      882     +108     
Flag Coverage Δ
gpu-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 7 files with indirect coverage changes

@flying-sheep flying-sheep merged commit b19a5ea into main Aug 21, 2023
14 checks passed
@flying-sheep flying-sheep deleted the fix-tests branch August 21, 2023 13:08
@scverse scverse deleted a comment from lumberbot-app bot Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix/Circumvent upcoming breakage in pandas 2.1.0
2 participants