feat(settings): basic log api and ui #337
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 1 alert when merging 7bc1b8a into df4ac83 - view on LGTM.com new alerts:
|
|
I converted this to a draft for now while we get it ironed out. |
sct
requested changes
Dec 17, 2020
| const messages = defineMessages({ | ||
| logs: 'Logs', | ||
| logsDescription: | ||
| 'You can access your logs directly in stdout (container logs) or looking in /app/config/logs/overseerr.logs', |
There was a problem hiding this comment.
We will want to have the same <code> tags in here like we did in the temporary message. If you only put the tags in here by themselves though, they will be just rendered out in the string.
You can see how this is done in the RequestList component. I apply tags in there.
Comment on lines
+44
to
+69
| <div className="mt-4 text-sm"> | ||
| {data?.map((row, index) => ( | ||
| <div key={`log-list-${index}`} className="space-x-2 text-gray-300"> | ||
| <span className="inline"> | ||
| <FormattedDate | ||
| value={row.timestamp} | ||
| year="numeric" | ||
| month="short" | ||
| day="2-digit" | ||
| /> | ||
| | ||
| <FormattedTime | ||
| value={row.timestamp} | ||
| hour="numeric" | ||
| minute="numeric" | ||
| second="numeric" | ||
| hour12={false} | ||
| /> | ||
| </span> | ||
| <span className="inline"> | ||
| [{row.level}][{row.label}]: | ||
| </span> | ||
| <span className="inline">{row.message}</span> | ||
| </div> | ||
| ))} | ||
| </div> |
There was a problem hiding this comment.
We can maybe re-use the table component here to make this look nice? Check out how i use it in the RequestList component.
|
@lochstar Are you still working on this? |
|
Planning on it, yes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This implements a very basic log UI. The number of rows returned is set to 1000. I thought I'd get this in so others can pick up from it and we can decide what we'd like from the log ui.
I separated the winston transport configs to use a JSON format for the file log, using the current text-based log that we output to the console wasn't compatible with
winston.query. We should probably set some options related to maximum files and filesize.As the format of the log
overseerr.loghas changed, we may need to purge or migrate an existing log on upgrade?Other features we could implement:
Screenshot (if UI related)
Issues Fixed or Closed by this PR