Custom chain ID from env

[levackt]

CHAINID via env var doesn't work, it's always secretdev-1

[levackt]

The problem is the logic is inverted, so if the shorthand in the PR isn't preferred, we can fix it like so;

if [[ -z "${CHAINID}" ]]; then
    chain_id="secretdev-1"
else
    chain_id=$CHAINID
fi

[levackt]

Also present here, but probably only used by CI with defaults

[assafmo]

Cool, didn't know of this syntax.

[Cashmaney]

This breaks the secretjs tests for whatever reason - I assume it's because the dev image sets a chain id and now it gets improperly set (when the tests expect the default secretdev-1). @levackt mind taking a look? It should be in either the dev-image or release dockerfiles

[levackt]

Sure, let me check

[levackt]

Tests look better, squashed the commits and undrafting, should build

[Cashmaney]

LGTM! Thanks @levackt, merging this now