WIP: CosmWasm v1 IBC Receive Hooks #966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here specifically is ibc-open-channel
assafmo
requested review from
Cashmaney,
reuvenpo,
toml01 and
liorbond
as code owners
OnTimeoutPacket OnAckPacket OnCloseChannel OnConnectChannel
Here specifically is ibc-open-channel
OnTimeoutPacket OnAckPacket OnCloseChannel OnConnectChannel
liorbond
force-pushed
the
cw-1-ibc-receive-hooks
branch
from
a4a2b1c to
a921247
Compare
liorbond
reviewed
Aug 17, 2022
x/compute/internal/keeper/keeper.go
Outdated
| @@ -1088,25 +1066,27 @@ func (k Keeper) reply(ctx sdk.Context, contractAddress sdk.AccAddress, reply v1w | |||
| consumeGas(ctx, gasUsed) | |||
|
|
|||
| if execErr != nil { | |||
| return nil, sdkerrors.Wrap(types.ErrReplyFailed, execErr.Error()) | |||
Fix 2 possible null drefs
Fix go linter warnings (including some more null-drefs)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.