Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create codeql.yml #964

Closed
wants to merge 7 commits into from
Closed

Create codeql.yml #964

wants to merge 7 commits into from

Conversation

faddat
Copy link
Collaborator

@faddat faddat commented Jul 14, 2022

Hey I think that this may need to run on a GR or we need to give it special permission to run on github actions but it's really really great.

It detects things like non-determinism errors.

@faddat faddat marked this pull request as ready for review July 14, 2022 04:44
@assafmo
Copy link
Member

assafmo commented Jul 14, 2022

Is this static analysis magic?

@faddat
Copy link
Collaborator Author

faddat commented Jul 14, 2022

it is exactly the static analysis magic

@Cashmaney
Copy link
Member

Very cool. Interested to see whether it will work out of the box, or if we'll need to tinker with it

@faddat
Copy link
Collaborator Author

faddat commented Jul 14, 2022

I find that setting the tag secretcli can help, locally. But also seems my local dev env "ain't quite right".

When I set the build tag, it works better but (eg: gopls) doesn't seem to work perfectly.

@Cashmaney
Copy link
Member

I find that setting the tag secretcli can help, locally. But also seems my local dev env "ain't quite right".

When I set the build tag, it works better but (eg: gopls) doesn't seem to work perfectly.

The secretcli tag just compiles without the SGX enclave part, so it's not really a complete build.

Also, are we missing anything else for this action to run? I was expecting the codeql workflow to be available in this branch already 🤔

@assafmo
Copy link
Member

assafmo commented Jul 19, 2022

@Cashmaney I believe the secretcli tag is used here to silence the VSCode IDE linkage errors

Cashmaney and others added 2 commits July 20, 2022 18:34
Just want to see if codeql will run now
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Sep 7, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: dbb42ff
Status: ✅  Deploy successful!
Preview URL: https://778a69e1.swagger-preview.pages.dev
Branch Preview URL: https://faddat-codeql.swagger-preview.pages.dev

View logs

@assafmo
Copy link
Member

assafmo commented Sep 8, 2022

#1020

@assafmo assafmo closed this Sep 8, 2022
@assafmo assafmo deleted the faddat/codeql branch September 11, 2022 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants