Test v1 BankMsg::Burn & v0.10+v1 CosmosMsg::Custom #962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
assafmo
requested review from
Cashmaney,
reuvenpo,
toml01 and
liorbond
as code owners
Plus remove reflect_test.go which will never be used that way because we never allow CustomMsg
|
Essentially inside the enclave CustomMsg was defined like this to make these tests pass, but in practice CustomMsg should always fail hare (v0.10) or here (v1). |
Using `git diff 6ce26f9 | git apply -R`
Co-authored-by: Jacob Gadikian <[email protected]>
assafmo
force-pushed
the
test-cw-v1-bankmsg-burn
branch
2 times, most recently
from
f7bfcec to
b47841a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also refactor the enclave v0.10 cosmwasm-std types in the and fix a very old bug. Not really an issue, just was a weird behavior, using CosmosMsg::Custom should always fail but it failed sooner than expected with a cryptic message because of a bug in the enclave v0.10 cosmwasm-std types.