Port dev image faucet from python to node #957 #959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, this will be useful:) Can you also remove the Python install from the docker image, and undraft this? I went ahead and changed the target branch so we can merge it into a feature branch and have the CI run properly before merging to master |
|
Great, although I thought I already removed Python here Undrafting and checking for anywhere else |
levackt
requested review from
Cashmaney,
reuvenpo,
toml01,
assafmo and
liorbond
as code owners
Oh yeah, missed that! |
levackt
commented
Jul 13, 2022
Merged
|
Do we have tests that use the faucet API? |
No problem, testing with setsid |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see if this is what you had in mind, if it's not already being handled anyway.