go 1.18 #947
Merged
go 1.18 #947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n on dev laptops.
faddat
requested review from
Cashmaney,
reuvenpo,
toml01,
assafmo and
liorbond
as code owners
Co-authored-by: Reuven Podmazo <[email protected]>
As xargo v0.3.26 contains breaking changes, specifically this: japaric/xargo@v0.3.25...v0.3.26#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5L147-R148 which caused an `error[E0463]: can't find crate for "core"` error when building Co-authored-by: Reuven Podmazo <[email protected]>
Also see a8f623f Co-authored-by: Reuven Podmazo <[email protected]>
|
thanks so much for the ci fixes on this and #946 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to bring us closer to the package selection that will be used on developer laptops.