Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#377 go over errors #393

Merged
merged 17 commits into from
Jul 14, 2020
Merged

#377 go over errors #393

merged 17 commits into from
Jul 14, 2020

Conversation

Cashmaney
Copy link
Member

@Cashmaney Cashmaney commented Jul 13, 2020

Main stuff:

  • Moved a lot of debug/info to trace so it doesn't clog up the stdout

  • Set the minimum log levels for the enclave as follows:

trace in SW mode
info in HW/non prod
warn in HW/prod

  • Changed error log text to be more human-readable. Examples:

wasm contract failed: generic: -> contract failed: encrypted:
FailedOcall -> failed to execute ocall

etc.

Itzik Grossman added 5 commits July 12, 2020 19:44
Also clean up useless files
Also clean up useless files
…retd-parse

# Conflicts:
#	cosmwasm/packages/wasmi-runtime/src/wasm/contract_operations.rs
@Cashmaney Cashmaney changed the title #377 go over errors WIP #377 go over errors Jul 13, 2020
Itzik Grossman added 7 commits July 13, 2020 17:30
Also clean up useless files
Also clean up useless files
Also clean up useless files
Also clean up useless files
Also clean up useless files
renamed generic: to encrypted: since it simply marks an encrypted string so...
Switched some more log levels
@Cashmaney Cashmaney changed the title WIP #377 go over errors #377 go over errors Jul 14, 2020
assafmo
assafmo previously approved these changes Jul 14, 2020
docs/post-mortems/testnet-halt-95.md Outdated Show resolved Hide resolved
go-cosmwasm/types/stderror.go Show resolved Hide resolved
x/compute/client/cli/query.go Show resolved Hide resolved
cosmwasm/packages/enclave-ffi-types/src/types.rs Outdated Show resolved Hide resolved
docs/post-mortems/testnet-halt-95.md Outdated Show resolved Hide resolved
x/compute/client/cli/query.go Outdated Show resolved Hide resolved
x/compute/internal/types/errors.go Show resolved Hide resolved
x/compute/internal/types/errors.go Show resolved Hide resolved
Itzik Grossman added 2 commits July 14, 2020 13:28
Itzik Grossman added 2 commits July 14, 2020 14:18
Switched some more log levels
Switched some more log levels
@Cashmaney Cashmaney merged commit bf3f616 into develop Jul 14, 2020
@Cashmaney Cashmaney deleted the #377-go-over-errors branch July 14, 2020 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants