Hardcoded upgrade admins #1522
Merged
Hardcoded upgrade admins #1522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en supplying a the previous code hash can trigger them
eshelB
requested review from
Cashmaney,
toml01,
assafmo and
liorbond
as code owners
assafmo
previously approved these changes
Aug 24, 2023
…ted logic on the rust file)
Cashmaney
requested changes
Aug 27, 2023
…e table on the original proposal
Cashmaney
approved these changes
Aug 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
probably this asks for a refactor to a new file for the hardcoded admins.
The addresses appear in the list in the proposal, but the hashes were queries from the chain. Let me know if you want to see the code that queried the hashes (built by chatGPT and tweaked by me).