Add missing RPC function and make proto file readable #1081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liorbond
requested review from
Cashmaney,
reuvenpo,
toml01 and
assafmo
as code owners
Cashmaney
requested changes
Aug 22, 2022
There was a problem hiding this comment.
When using addresses as "github.com/cosmos/cosmos-sdk/types.AccAddress" they are encoded in url unsafe base64 and cannot be used safely in the query - some will fail, and the others will be uncoded in a weird way. Use "string" instead to get the bech32 encoded address that we're looking for
Cashmaney
approved these changes
Aug 23, 2022
|
Replaced by #1130 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.