lint / codeql

cmd/secretd/attestation.go

@@ -155,7 +155,7 @@ blockchain. Writes the certificate in DER format to ~/attestation_cert
 			userHome, _ := os.UserHomeDir()
 
 			// Load consensus_seed_exchange_pubkey
-			cert := []byte(nil)
+			var cert []byte
 			if len(args) >= 1 {
 				cert, err = os.ReadFile(args[0])
 				if err != nil {

cmd/secretd/root.go

@@ -8,7 +8,6 @@ import (
 	"path/filepath"
 	"strings"
 
-	"github.com/cosmos/cosmos-sdk/codec"
 	serverconfig "github.com/cosmos/cosmos-sdk/server/config"
 	"github.com/cosmos/cosmos-sdk/types/module"
 	authcmd "github.com/cosmos/cosmos-sdk/x/auth/client/cli"
@@ -315,8 +314,8 @@ func exportAppStateAndTMValidators(
 ) (servertypes.ExportedApp, error) {
 	bootstrap := viper.GetBool("bootstrap")
 
-	encCfg := app.MakeEncodingConfig()
-	encCfg.Marshaler = codec.NewProtoCodec(encCfg.InterfaceRegistry)
+	// encCfg := app.MakeEncodingConfig()
+	// encCfg.Marshaler = codec.NewProtoCodec(encCfg.InterfaceRegistry)
 	var wasmApp *app.SecretNetworkApp
 	if height != -1 {
 		wasmApp = app.NewSecretNetworkApp(logger, db, traceStore, false, map[int64]bool{}, "", uint(1), bootstrap, appOpts, compute.DefaultWasmConfig())

x/compute/client/cli/query.go

@@ -313,6 +313,9 @@ func CmdDecryptText() *cobra.Command {
 			}
 
 			nonce, originalTxSenderPubkey, ciphertextInput, err := parseEncryptedBlob(dataCipherBz)
+			if err != nil {
+				return fmt.Errorf("error while trying to parse encrypted blob: %w", err)
+			}
 
 			wasmCtx := wasmUtils.WASMContext{CLIContext: clientCtx}
 			_, myPubkey, err := wasmCtx.GetTxSenderKeyPair()

x/compute/handler.go

@@ -20,7 +20,7 @@ func NewHandler(k Keeper) sdk.Handler {
 		ctx = ctx.WithEventManager(sdk.NewEventManager())
 
 		switch msg := msg.(type) {
-		case *MsgStoreCode: //nolint
+		case *MsgStoreCode: 
 			return handleStoreCode(ctx, k, msg)
 		case *MsgInstantiateContract:
 			return handleInstantiate(ctx, k, msg)

x/compute/internal/keeper/test_common.go

@@ -527,7 +527,7 @@ func TestHandler(k Keeper) sdk.Handler {
 		ctx = ctx.WithEventManager(sdk.NewEventManager())
 
 		switch msg := msg.(type) {
-		case *wasmtypes.MsgInstantiateContract: //nolint
+		case *wasmtypes.MsgInstantiateContract:
 			return handleInstantiate(ctx, k, msg)
 		case *wasmtypes.MsgExecuteContract:
 			return handleExecute(ctx, k, msg)

x/registration/alias.go

@@ -1,4 +1,4 @@
-// nolint
+
 // autogenerated code using github.com/rigelrozanski/multitool
 // aliases generated for the following subdirectories:
 // ALIASGEN: github.com/scrtlabs/SecretNetwork/x/compute/internal/types

x/registration/internal/keeper/legacy_querier.go

@@ -38,16 +38,15 @@ func NewLegacyQuerier(keeper Keeper) sdk.Querier {
 			}
 			return bz, nil
 		case QueryMasterCertificate:
-			rsp, err = queryMasterKey(ctx, keeper) //nolint:staticcheck
-
+			rsp, err = queryMasterKey(ctx, keeper)
 			if err != nil {
 				return nil, err
 			}
 
-			if rsp == nil || reflect.ValueOf(rsp).IsNil() { //nolint:staticcheck
+			if reflect.ValueOf(rsp).IsNil() {
 				return nil, nil
 			}
-			// why indent?
+
 			bz, err = json.Marshal(rsp)
 			if err != nil {
 				return nil, sdkerrors.Wrap(sdkerrors.ErrJSONMarshal, err.Error())

x/registration/remote_attestation/remote_attestation.go

@@ -220,7 +220,7 @@ func verifyAttReport(attnReportRaw []byte, pubK []byte) ([]byte, error) {
 				if err != nil && len(platInfo) != 105 {
 					return nil, errors.New("illegal PlatformInfoBlob")
 				}
-				platInfo = platInfo[4:] //nolint:staticcheck
+				// platInfo = platInfo[4:]
 
 				// piBlob := parsePlatform(platInfo)
 				// piBlobJson, err := json.Marshal(piBlob)