Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rollup-relayer): check if previous bundle or batch is finalized in fake finalize mode #1563

Conversation

colinlyguo
Copy link
Member

@colinlyguo colinlyguo commented Nov 15, 2024

Purpose or design rationale of this PR

This PR adds a check that if last bundle or batch is finalized in fake finalize bundle mode before finalizing a new bundle. Because the contract does not verify if the previous bundle or batch is finalized.

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • fix: A bug fix

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change

Summary by CodeRabbit

  • New Features

    • Incremented version number to v4.4.73, indicating a new release.
  • Bug Fixes

    • Enhanced validation in the bundle finalization process to ensure prerequisites are met before proceeding, improving robustness and error handling.
    • Updated logging for clarity in error messages related to bundle finalization.

Copy link

coderabbitai bot commented Nov 15, 2024

Walkthrough

The changes in this pull request involve an update to the version number in the common/version/version.go file, changing it from "v4.4.72" to "v4.4.73". Additionally, modifications to the ProcessPendingBundles method in the rollup/internal/controller/relayer/l2_relayer.go file introduce new validation checks to ensure that the last batch is finalized before finalizing a bundle without proof, along with improved error logging for clarity.

Changes

File Path Change Summary
common/version/version.go Updated version tag from "v4.4.72" to "v4.4.73".
rollup/internal/controller/relayer/l2_relayer.go Modified ProcessPendingBundles to add validation checks for last batch finalization and improved error logging.

Possibly related PRs

Suggested labels

bump-version

Suggested reviewers

  • georgehao
  • 0xmountaintop

🐰 In the meadow, the rabbits play,
A version bump brightens the day!
With bundles checked, we hop with glee,
Finalizing safely, as it should be.
Hooray for code, so neat and bright,
Together we code, from morning till night! 🌼

Warning

Rate limit exceeded

@colinlyguo has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 12 minutes and 45 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 7695206 and ac48260.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 7695206 and ac48260.

📒 Files selected for processing (1)
  • rollup/internal/controller/relayer/l2_relayer.go (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • rollup/internal/controller/relayer/l2_relayer.go

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 10.52632% with 17 lines in your changes missing coverage. Please review.

Project coverage is 52.73%. Comparing base (3ab5752) to head (ac48260).

Files with missing lines Patch % Lines
rollup/internal/controller/relayer/l2_relayer.go 10.52% 14 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1563      +/-   ##
===========================================
- Coverage    52.78%   52.73%   -0.06%     
===========================================
  Files          157      157              
  Lines        12652    12668      +16     
===========================================
+ Hits          6678     6680       +2     
- Misses        5392     5403      +11     
- Partials       582      585       +3     
Flag Coverage Δ
rollup 58.89% <10.52%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 3ab5752 and 912561a.

📒 Files selected for processing (2)
  • common/version/version.go (1 hunks)
  • rollup/internal/controller/relayer/l2_relayer.go (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • common/version/version.go

rollup/internal/controller/relayer/l2_relayer.go Outdated Show resolved Hide resolved
0xmountaintop
0xmountaintop previously approved these changes Nov 15, 2024
yiweichi
yiweichi previously approved these changes Nov 16, 2024
zimpha
zimpha previously approved these changes Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants