fix(rollup-relayer): check if previous bundle or batch is finalized in fake finalize mode #1563
Conversation
…n fake finalize mode
WalkthroughThe changes in this pull request involve an update to the version number in the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Warning Rate limit exceeded@colinlyguo has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 12 minutes and 45 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1563 +/- ##
===========================================
- Coverage 52.78% 52.73% -0.06%
===========================================
Files 157 157
Lines 12652 12668 +16
===========================================
+ Hits 6678 6680 +2
- Misses 5392 5403 +11
- Partials 582 585 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (2)
common/version/version.go(1 hunks)rollup/internal/controller/relayer/l2_relayer.go(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- common/version/version.go
colinlyguo
dismissed stale reviews from yiweichi and 0xmountaintop
via
7695206
colinlyguo
deleted the
fix-rollup-relayer-check-if-last-finalize-bundle-is-finalized-in-fake-finalize-mode
branch
Purpose or design rationale of this PR
This PR adds a check that if last bundle or batch is finalized in fake finalize bundle mode before finalizing a new bundle. Because the contract does not verify if the previous bundle or batch is finalized.
PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
Deployment tag versioning
Has
tagincommon/version.gobeen updated or have you addedbump-versionlabel to this PR?Breaking change label
Does this PR have the
breaking-changelabel?Summary by CodeRabbit
New Features
Bug Fixes