Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll dev 0804 #44

Merged
merged 54 commits into from
Aug 16, 2022
Merged

Scroll dev 0804 #44

merged 54 commits into from
Aug 16, 2022

Conversation

lispc
Copy link
Collaborator

@lispc lispc commented Aug 4, 2022

release files: s3://circuit-release/circuit-release/release-0804-degree25.

a new params25 is used now.

 $ sudo aws  --profile default s3 ls s3://circuit-release/circuit-release/release-0804-degree25/ --recursive
2022-08-11 01:41:19       7911 circuit-release/release-0804-degree25/full_proof.data
2022-08-11 01:41:19        575 circuit-release/release-0804-degree25/sha256sum
2022-08-11 01:41:19   16777288 circuit-release/release-0804-degree25/test_params/params18
2022-08-11 01:41:19 2147483720 circuit-release/release-0804-degree25/test_params/params25
2022-08-11 01:41:19         16 circuit-release/release-0804-degree25/test_seed
2022-08-11 01:41:19      36679 circuit-release/release-0804-degree25/verifier.sol
2022-08-11 01:41:19        736 circuit-release/release-0804-degree25/verify_circuit.vkey

notes:

  1. many fixes for testnet block result fix: fix accountCreated handling, add storageTrace, fix DELEGATECALL/STATICCALL caller state #42
  2. upgrade zkevm-circuit to 0801.
  3. upgrade halo2-snark-aggregator to 0804. (big refactor). Solidity verifying gas reduce to 1M(by Gaoxin, I did not check this). change default AGG_DEGREE=25, so peak memory and proving time will be reduced to about 50%-60% of original.

breaking changes:

  1. AggProof changed. proof_rust and proof_solidity are merged into proof. instance_commitments removed. Add a 128byte "final_pair"
  2. Solidity calldata are encoded in little endian. example : https://github.com/scroll-tech/halo2-snark-aggregator/blob/d3dcc83c0fa881f22295be7de83c1aad9e63ca6d/halo2-snark-aggregator-solidity/waffle/test/Verifier.test.ts#L66

@lispc
Copy link
Collaborator Author

lispc commented Aug 9, 2022

@Lawliet-Chan ci error

@lispc
Copy link
Collaborator Author

lispc commented Aug 12, 2022

@noel2004 can you help me fix the merge conflict? related to mpt trace

@scroll-dev scroll-dev merged commit 216e372 into main Aug 16, 2022
@scroll-dev scroll-dev deleted the scroll-dev-0804 branch August 16, 2022 07:42
@lispc lispc restored the scroll-dev-0804 branch August 16, 2022 08:44
@0xmountaintop 0xmountaintop deleted the scroll-dev-0804 branch September 16, 2022 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants