Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bytes48 not supported by l2geth in syncUpstream #26

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

jonastheis
Copy link
Contributor

Purpose or design rationale of this PR

This PR removes the bytes48 ABI argument as it is invalid according to spec bytes<M>: binary type of M bytes, 0 < M <= 32 and has been fixed upstream and thus is not compatible anymore with the l2geth upstream version.

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change
  • Yes

@jonastheis jonastheis requested a review from colinlyguo August 21, 2024 08:22
@colinlyguo colinlyguo merged commit 3ad820b into main Aug 22, 2024
3 checks passed
@colinlyguo colinlyguo deleted the jt/fix-bytes48 branch August 22, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants