Remove unnecessary goldilocks patch
#481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We specify Goldilocks as a git dependency, but then immediately patch it. Let's stop doing that.
matthiasgoergens
requested review from
naure and
hero78119
and removed request for
naure
yczhangsjtu
approved these changes
Oct 28, 2024
|
Maybe fork goldilocks repo to |
hero78119
approved these changes
Oct 28, 2024
+1 for migrate to scroll-tech for temp. The ultimate solution suggest follow #483 which porting Goldilock from plonky2 instead |
|
Yes, we should do all of these things. I'm just cleaning up the patching here in the meantime. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We specify Goldilocks as a git dependency, but then immediately patch it. Let's stop doing that.