-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v0.7.2: PHP 8 = requirement(?) #8
Comments
sommer-gei
added a commit
to sommer-gei/php-sru-client
that referenced
this issue
Jul 18, 2023
* + PHP 8 notes * see scriptotek#8
Merged
Thanks for letting us know! I can't guarantee anything as I'm totally busy right now, but maybe I can take a look over the weekend 😉 |
Sorry about that, @sommer-gei, I should have created a major release for this change! Pinning to 0.7.1 is the solution for PHP < 8 . I'll keep the issue open so it's easy for others to find |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hey @danmichaelo + @S1SYPHOS !
Today I made a little update to one of my projects, where I'm glad to use
php-sru-client
, and mentioned composer updated this package from version0.7.1
to0.7.2
. After that my script ended with the following error, while doing a SRU request:After some investigation and code research I came up with the following 3 things:
0.7.2
; I initiated the project only some weeks ago = when0.7.2
was still out.0.7.1
to0.7.2
introduced PHP 8.0 as minimum PHP version.CHANGELOG.md
misses the IMHO important change for0.7.2
(see 2.).My current fix is to pin this package (by composer) to
0.7.1
, to use it with PHP 7.4.I also will add some notes to
CHANGELOG.md
and make a PR.Thanks for fixing in advance and KR!
The text was updated successfully, but these errors were encountered: