Skip to content
This repository has been archived by the owner on Dec 3, 2022. It is now read-only.

integration with other extension*s #4

Closed
maxwowpow opened this issue Feb 9, 2015 · 6 comments
Closed

integration with other extension*s #4

maxwowpow opened this issue Feb 9, 2015 · 6 comments
Labels

Comments

@maxwowpow
Copy link

Hello & thank you for the extension, wrapped strings look cleanier and nicer!

Is there a chance you could try to determine, whether "SpellCheck" extension interferes with the functionality of "indent-softwraps" and there is a way to fix it? Thanks.

Repro:
install spell-check (https://github.com/couzteau/SpellCheck)
install brackets-indent-softwraps.
write some multiline text of random letters to be "soft wrapped".
when text is soft-wrapped select text and run spellCheck (right click >> English e.g.).

Expected:
text highlighted on "misspelled" words", soft wrap intact.

What happens:
letters overlap:
2015-02-09 16_13_52-pages_loremipsum html website - brackets

Possible problem:
Both developers assume, that text is the same / original / not manipulated.

Possible solution:
Check before applying the action whether there was some text manipulation and either reset it (?) or restore it after (?)

CC: @couzteau
https://github.com/couzteau/SpellCheck

@scriptin
Copy link
Owner

scriptin commented Feb 9, 2015

Thank you! Found possible fix, opened an issue: couzteau/SpellCheck/issues/13

@scriptin
Copy link
Owner

scriptin commented Feb 9, 2015

By the way, have you seen similar issues with any other extensions?

@couzteau
Copy link

pushed spellcheck 0.5.8 with proposed fix.

@maxwowpow
Copy link
Author

Thanks, now it's ok!

Re: similar issues
yes and no > #5

@scriptin
Copy link
Owner

I found out what was the issue: http://jsfiddle.net/pr3xc5ny/3/

It is because nested inline-block elements were inheriting text-indent property. That's what also caused indentation to fail on tabs - see /pull/3 - that's why .cm-tab { display: inline; } worked.

Version 0.2.1 is out, seems to work OK.

@couzteau As I was afraid of, that was a failure on my part

@couzteau
Copy link

Hey No worries. Spell check works just fine using inlinein the context. Thanks for following up.

@scriptin scriptin added the bug label Feb 13, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants