-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
workflow to run go test #15
Conversation
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! It'd be great to have you! Maintainer checklist
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @daveads!
Thank you for your patience with my review 😅 Apologies for the wait
I added a couple thoughts if you have interest in taking a look, but I can also make the changes myself, if not - no worries
Thanks again!
.github/workflows/ci.yml
Outdated
- name: Setup Go | ||
uses: actions/setup-go@v4 | ||
with: | ||
go-version: '1.22.2' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The go version that Scribe-Server uses is 1.20
(as in the go.mod
file). This is due to the version that was available in Toolforge, where Scribe-Server is hosted.
We should probably test against the same version that Scribe-Server is on 🤔 That got me thinking though.. could we get this action to read the version off the go.mod
file in case we change the version? I checked the docs and lo and behold, it looks like we can! 🚀 Doing this would be great
.github/workflows/ci.yml
Outdated
- name: Build | ||
run: make build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- name: Build | |
run: make build |
We can probably remove this build step for now actually. Running the tests is probably sufficient here.
Eventually, we could have some automation for the build step, but it probably makes sense for that to be a separate future workflow.
.github/workflows/ci.yml
Outdated
@@ -0,0 +1,24 @@ | |||
name: CI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thinking here that we could name this workflow in the same way that we did for Scribe-Data actually, pr_ci.yaml
We could name this pr_ci
as well and the file pr_ci.yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay
I made the final change to read the go version from the |
Description
Set up workflow to run golang test using "make"
This issue >> #8