fix: Fix job name search #1282
Merged
fix: Fix job name search #1282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
With this change, if displayName annotation is set can you not search by original job name? |
That would be the case for now, yes. I need to spend a little bit more time to see if I can get the search to work for both the original job name and the display name. As it currently stands, the display name, if configured, would be the one that is expected to be found as the original name requires a mouse-over to display |
|
I'm not sure what is expected behavior from the user. But I guess for now it makes sense that you can search by what you can see |
tkyi
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
When searching for a job in the v2 jobs table, jobs that have a display name annotation configured are not able to be search for properly
Objective
Fixes the job name so that it is searchable.
References
screwdriver-cd/screwdriver#3200
License
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.