Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(3230): fix assigned remote trigger events #3231

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

yakanechi
Copy link
Contributor

Context

#3230

Objective

Fix external events triggered by the same event to be combined into one event.
In addition, fix the behavior on restart as follows.

  • External events created when restarted with an upstream event belong to the same groupEvent as the external event created by the event before the restart.
  • A remote trigger from a downstream event to an upstream event belongs to the same groupEvent as the upstream event that created the restarted downstream event.

Start event(Upstream), Downstream event
after-upstreamafter-upstream-restart

Restart event(Upstream), Downstream event
after-downstreamafter-downstream-restart

Relatedly, A Issues has been resolved too.
#3177

References

#3230
#3177

License

I confirm that this contribution is made under a BSD license and that I have the authority necessary to make this contribution on behalf of its copyright owner.

@coveralls
Copy link

Coverage Status

coverage: 95.202% (+0.02%) from 95.185%
when pulling 0b4369c on sonic-screwdriver-cd:fix-gropEventId
into ef31fca on screwdriver-cd:master.

@tkyi tkyi merged commit ffdfc1d into screwdriver-cd:master Oct 24, 2024
2 checks passed
@yakanechi yakanechi deleted the fix-gropEventId branch October 24, 2024 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants