fix(2646): Do not include parameters from external builds during remote join #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sagar1312
force-pushed
the
sagar1312_fix2646_excludeExternalParameters
branch
from
651039e to
492be64
Compare
adong
previously approved these changes
Feb 17, 2022
sagar1312
force-pushed
the
sagar1312_fix2646_excludeExternalParameters
branch
from
32a4bfd to
1991f07
Compare
sagar1312
force-pushed
the
sagar1312_fix2646_excludeExternalParameters
branch
from
1991f07 to
2043753
Compare
adong
previously approved these changes
Feb 18, 2022
tkyi
reviewed
Feb 18, 2022
launch.go
Outdated
|
|
||
| // Always exclude parameters from external meta | ||
| delete(externalParentBuildMeta, "parameters") | ||
|
|
||
| resultMeta = deepMergeJSON(resultMeta, parentBuild.Meta) |
There was a problem hiding this comment.
is this what you meant to do?
Suggested change
| resultMeta = deepMergeJSON(resultMeta, parentBuild.Meta) | |
| resultMeta = deepMergeJSON(resultMeta, externalParentBuildMeta) |
tkyi
requested changes
Feb 18, 2022
tkyi
approved these changes
Feb 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Parameters from external builds are being included during remote join.
Objective
Parameters must be available only to pipeline and its jobs. Parameters from external builds (jobs of another pipeline) should not be made available to the jobs during remote join.
References
screwdriver-cd/screwdriver#2646
License
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.