[UEPR-44] Implemented custom journeys for onboarding #8801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sashodada
reviewed
Oct 14, 2024
src/views/preview/project-view.jsx
Outdated
Comment on lines
60
to
61
| props.projectId && | ||
| prevProjectId === '0' && |
There was a problem hiding this comment.
If we're checking for prevProjectId === '0' and projectId cannot be null or undefined, do we need the first truthy check (the props.projectId one)?
MiroslavDionisiev
changed the base branch from
develop
to
onboarding-integration
…ase/2024-10-16 [Develop] release/2024-10-16
sashodada
approved these changes
Oct 18, 2024
MiroslavDionisiev
merged commit f98be9e
into
scratchfoundation:onboarding-integration
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket
UEPR-44
Changes:
query-stringlibrary to allow parsing boolean valuesdriver.jslibrary for creating the journeystutorial=allquery parameter after new project is created when opening editor from ideas pageEditor onboarding journey
Tutorials highlight after user picks On Own option
Project onboarding journey if user picks Starter project option