Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass fixupSvgString into paint editor #6556

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

adroitwhiz
Copy link
Contributor

@adroitwhiz adroitwhiz commented Jan 9, 2021

Depends on scratchfoundation/scratch-svg-renderer#209 and scratchfoundation/scratch-svg-renderer#210

Resolves

Proposed Changes

This PR passes the fixupSvgString function into the paint editor component.

Reason for Changes

This allows us to call fixupSvgString from the paint editor without it depending on scratch-svg-renderer itself.

Test Coverage

Tested manually

Browser Coverage

Check the OS/browser combinations tested (At least 2)

Mac

  • Chrome
  • Firefox
  • Safari

Windows

  • Chrome
  • Firefox
  • Edge

Chromebook

  • Chrome

iPad

  • Safari

Android Tablet

  • Chrome

Linux

  • Firefox

@adroitwhiz
Copy link
Contributor Author

To those reviewing this: it's here as a prerequisite to scratchfoundation/scratch-paint#1346, which replaces the "fixup SVG string" step in the paint editor with the fixupSvgString function defined in scratch-svg-renderer and used everywhere else. This doesn't touch the VM's asset code, so it should not cause another situation like scratchfoundation/scratch-vm#3026.

@kchadha kchadha removed their assignment Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SVG fixes should be moved to svg-renderer's fix-up-svg
3 participants