Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On mobile, FlyoutButton click only recognized when button text is tapped #1205

Closed
msintov opened this issue Nov 2, 2017 · 2 comments
Closed

On mobile, FlyoutButton click only recognized when button text is tapped #1205

msintov opened this issue Nov 2, 2017 · 2 comments
Labels
bug help wanted
Milestone
Backlog

Comments

@msintov
Copy link

msintov commented Nov 2, 2017

Expected Behavior

On mobile, upon tapping inside button border but not tapping on text, button click is recognized.

Actual Behavior

On mobile, tapping inside the button border on the empty space within the button is not recognized as a click.

Steps to Reproduce

  1. Load vertical_playground.html.
  2. From Google Chrome menu, select View > Developer > Developer Tools and then select a device of your choice (e.g. iPad Pro).
  3. Select Data category so that "Create Variable" button is visible in the flyout.
  4. Tap inside the "Create Variable" button without tapping on the button text. For instance, tap between the left edge of the button and the start of the text, or tap between the end of the text and the right edge of the button.

Workaround: Tap the button text, and the button will be clicked.

Note: This issue doesn't happen on desktop (or when Developer Tools are not used).

Operating System and Browser

Mac OS 10.11.6 Google Chrome 62.0.3202.62
@thisandagain thisandagain added this to the Backlog milestone Nov 3, 2017
@mrjacobbloom
Copy link
Contributor

Possible duplicate of #941 and #1073

madPO pushed a commit to madPO/scratch-blocks that referenced this issue Nov 11, 2017
@ewpatton @paulkaplan
Implement Blockly.Events.filter in linear time (scratchfoundation#1205)
9102848 
* Implement Blockly.Events.filter in linear time

For large App Inventor projects (order 1k+ blocks, 100+ top-level
blocks), the O(n^2) behavior of Blockly.Event.filter was causing
performance issues when rearranging blocks or pasting from the
backpack. This commit provides a linear merge implementation using a
key that uniquely identifies a block so that multiple events targeting
the same block are merged. This change benefits from O(1) amortized
lookup using an object as a key-value store.

* Add event filter unit tests and fix logic bugs

* Update Blockly.Events.filter unit tests
madPO pushed a commit to madPO/scratch-blocks that referenced this issue Nov 11, 2017
@paulkaplan
Revert "Implement Blockly.Events.filter in linear time (scratchfounda…
8263afc 
…tion#1205)"

This reverts commit 9102848.
madPO pushed a commit to madPO/scratch-blocks that referenced this issue Nov 11, 2017
@paulkaplan
Merge pull request scratchfoundation#1161 from paulkaplan/fix-stack-c…
514fc04 
…lick-event

Revert "Implement Blockly.Events.filter in linear time (scratchfoundation#1205)"
@msintov msintov mentioned this issue Dec 20, 2017
Closed
@thisandagain
Copy link
Contributor

Tracking in #941

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@thisandagain @msintov @mrjacobbloom