Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set playwright_page request meta key early #91

Merged
merged 1 commit into from
May 9, 2022

Conversation

elacuesta
Copy link
Member

Closes #82

@codecov
Copy link

codecov bot commented May 9, 2022

Codecov Report

Merging #91 (8cb3518) into master (fa7d5f1) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #91   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          284       285    +1     
=========================================
+ Hits           284       285    +1     
Impacted Files Coverage Δ
scrapy_playwright/handler.py 100.00% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@elacuesta elacuesta merged commit 251bdc7 into master May 9, 2022
@elacuesta elacuesta deleted the set-playwright-page-meta-key-early branch May 9, 2022 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KeyError: 'playwright_page' when using errback
1 participant