Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for remote firefox and webkit #280

Closed
wants to merge 1 commit into from

Conversation

Ehsan-U
Copy link

@Ehsan-U Ehsan-U commented Jun 29, 2024

@Ehsan-U Ehsan-U changed the title add support for remote firefox or webkit add support for remote firefox and webkit Jun 29, 2024
@elacuesta
Copy link
Member

Thanks for the contribution. Unfortunately, I don't think it's a good idea to reuse the PLAYWRIGHT_CDP_URL setting for a non-CDP connection.

@elacuesta elacuesta closed this Jul 1, 2024
@Ehsan-U
Copy link
Author

Ehsan-U commented Jul 1, 2024

Thanks for feedback!

Another option would be to add a separate setting for Firefox and WebKit using the PLAYWRIGHT_RDP_URL

RDP is Remote Debugging Protocol. While I'm not certain if Playwright uses this protocol to connect to Firefox and WebKit, I can't think of another way it might be done.

@elacuesta
Copy link
Member

Indeed, see #283.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants