Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page init callback #128

Merged
merged 7 commits into from
Oct 3, 2022
Merged

Page init callback #128

merged 7 commits into from
Oct 3, 2022

Conversation

elacuesta
Copy link
Member

@elacuesta elacuesta commented Oct 2, 2022

Closes #25

Add playwright_page_init_callback request meta key.

Tasks:

  • Code
  • Docs
  • Example
  • Tests

@codecov
Copy link

codecov bot commented Oct 2, 2022

Codecov Report

Merging #128 (980fe66) into main (8cff562) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #128   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          304       311    +7     
=========================================
+ Hits           304       311    +7     
Impacted Files Coverage Δ
scrapy_playwright/handler.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@elacuesta elacuesta changed the title Initialize page upon creation Page init callback Oct 3, 2022
@elacuesta elacuesta marked this pull request as ready for review October 3, 2022 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add_init_script seems not to be implemented
1 participant