fix leaks in SendWithCallbacks function #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greetings, came across a heavy CPU load for a constant time, saw a recent PR that goroutine leaks have been fixed. With perf analysed the situation and saw that there are indeed goroutine leaks in SendWithCallbacks. Unlike a simple leak, where we have dead goroutines and degrade the scheduler, these goroutines are still engaged in a perpetual check of the CallbacksPattern, which resulted in 100% CPU utilisation. I had my CPU running at 100% like that for a week, even though it should have been doing no work at all. I will also attach a screenshot with perf, that in the rest of the programme all the load is on the check.
As for backwards compatibility, I don't think I had any problems with the programme hanging, timeout worked fine