Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/linterupdates #125

Merged
merged 4 commits into from
Apr 1, 2023
Merged

Chore/linterupdates #125

merged 4 commits into from
Apr 1, 2023

Conversation

carlmontanari
Copy link
Contributor

  • updates golangci-lint settings (adds stuff, fixes bad config)
  • fixes allocation for multi response output (was allocating then appending as apposed to stuffing output in the right index in the array)
  • re-gens test data after the previous update
  • removes unnecessary nolints
  • fixes some too long lines (purely cosmetic)
  • makes a few numbers consts (cosmetic)
  • checks error in channel read with errors.Is instead of equality (to io.EOF)
  • checks type assertions in a few places we just assumed that type assertions would be ok (they probably would be... but now we explicitly check and... still panic, but at least we did it explicitly and w/ a message of our own!)

@carlmontanari carlmontanari merged commit 6200445 into main Apr 1, 2023
@carlmontanari carlmontanari deleted the chore/linterupdates branch April 1, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant