Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update regex to allow BOF config prompt on SROS #183

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

kaelemc
Copy link
Contributor

@kaelemc kaelemc commented Jan 7, 2025

Description

This is a fairly simple change which improves the SROS regex allowing for:

  • Allow for BOF configuration mode in the MD-CLI prompt.

We rely on it for hellt/vrnetlab#297 😄

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Tested with the vrnetlab code here. Basically, applies a bootstrap config to the vSIM using Scrapli via telnet.

  • Tested with 24.10.R1

Here are some regex101 links to display the matching:

old new

Please let me know if I missed anything or if you need any more info!

Checklist:

  • My code follows the style guidelines of this project (no GitHub actions complaints! run make lint before
    committing!)
  • I have commented my code, pydocstyle and darglint are happy, docstrings are in google docstring format, and all
    docstrings include a summary, args, returns and raises fields (even if N/A)
  • I have added tests that prove my fix is effective or that my feature works, if adding "functional" tests please
    note if there are any considerations for the vrnetlab setup
  • New and existing unit tests pass locally with my changes

@carlmontanari
Copy link
Contributor

LGTM, thanks @kaelemc :D

@carlmontanari carlmontanari merged commit d862833 into scrapli:main Jan 7, 2025
11 checks passed
@kaelemc
Copy link
Contributor Author

kaelemc commented Jan 7, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants