Adding capability to run in background and send messages. #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactoring loop to handle_events. Running on background. Adding lock and moving loop out of dispatcher.
|
This is a pretty major change to the behavior of the bot. In particular, it seems to remove the thread pool by default. Can you document some use cases? Might be nice to compare this approach to the one taken in #95. Is there any way to test this change? |
|
ping @cristianowa |
|
Closing this since has been a while. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the intent to provide a better interface for doing things like the #42 I made a modification so, if needed, the bot can be executed in background and can be used to send messages still.
Based on that one can do the cron execute after it and just call bot.send_message().
For doing that I moved the loop from the dispatcher to to the bot and created a thread if it was running on background.
If used with default parameters, the behavior remains the same.