Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Json value refactor: Js.Json.t instead of the hacky Value.type #8

Merged
merged 3 commits into from
May 26, 2021
Merged

Json value refactor: Js.Json.t instead of the hacky Value.type #8

merged 3 commits into from
May 26, 2021

Conversation

gaku-sei
Copy link
Contributor

@gaku-sei gaku-sei commented May 25, 2021 •
edited
Loading

Closes #6

@gaku-sei gaku-sei force-pushed the json-value-refactor branch from f5c03f4 to 66cff90 Compare May 25, 2021 12:11
@gaku-sei gaku-sei merged commit 0c6ed01 into main May 26, 2021
@gaku-sei gaku-sei deleted the json-value-refactor branch May 26, 2021 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Normalize API: use Js.Json.t instead of Js.Dict.t<Value.t>
1 participant
@gaku-sei