Return an union type in Validation functions #19
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haoScoville
reviewed
Aug 10, 2022
| @@ -0,0 +1,5 @@ | |||
| @unboxed type rec t = Any('value): t | |||
There was a problem hiding this comment.
I don't seem to understand this line. Can you explain it in more details? And why should we wrap the handler with Any?
haoScoville
approved these changes
Aug 10, 2022
There was a problem hiding this comment.
Everything looks fine, I'll approve this PR and take some time to read about Union type in Rescript. Thank you @vtrofin
|
Closing the pr without merging because i found there is some custom implementation in Ats-client without returning different types from the validation function. See here where we map the error type into a custom error message. Having in mind we're moving away from ReScript i'll go with the existing error mapping rather than add another level of complexity with an union type return on validation functions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue
Our custom validation function need to be able to return custom error messages in case the input value is invalid.
The fix
In order to return custom error messages, we need to enable our custom validation function to return either a boolean or a string instead of a falsy value. I've created a new union type and i've updated the Example in this repository with a couple of validation functions, one of which will return a custom error message string.