Add the trigger function #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaku-sei
changed the title
infothien
approved these changes
Aug 26, 2021
|
It's rather simple, the 2 dates for interviews must be before/after the other one, so I need to revalidate both date on blur 😄 |
vtrofin
reviewed
Aug 26, 2021
| @send external triggerMultiple: (t, array<string>) => unit = "trigger" | ||
|
|
||
| @send | ||
| external triggerAndFocus: (t, string, @as(json`{ shouldFocus: true }`) _) => unit = "trigger" |
There was a problem hiding this comment.
why did we have to compile the string into the json here? Based on the provided example in the react hook form docs, this doesn't look to be json trigger('name', { shouldFocus: true })
There was a problem hiding this comment.
It's just the way to "inject" valid json value into js from rescript.
Also, keep in mind a json value is basically.... an object in js 😄
vtrofin
approved these changes
Aug 26, 2021
|
I'm really curious to see the finished example on how the trigger will help in this case, for targetNumbers i used a more rudimentary approach to validate dates so that one is after the other. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements https://react-hook-form.com/api/useform/trigger/
I used
@send externalinstead of just adding it to the record to have more flexibility with no runtime costs. The API is a bit less consistent but more flexible. We could refactor records to use this technic too 😕