Add a classify function for onChange argument
#16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
infothien
reviewed
Aug 17, 2021
| unknown->Js.Nullable.return->Js.Nullable.isNullable->not && | ||
| Obj.magic(unknown)["_reactName"] == "onChange" | ||
| ? Event(Obj.magic(unknown)) | ||
| : Value(Obj.magic(unknown)) |
There was a problem hiding this comment.
just to confirm this one is just for checking what kind of type of Argument that passed via the onClick function in rescript-hook-form right @gaku-sei .
There was a problem hiding this comment.
Exactly. To be honest it's not perfect and you can "fool" it, but it's rather unlikely to happen 😕
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normally this logic is done by react-hook-form in the
onChangecallback, but it's useful to be able to look at what theonChangeargument is when you implement your own logic.