Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalize value representation #15

Merged
merged 1 commit into from
Aug 17, 2021
Merged

Normalize value representation #15

merged 1 commit into from
Aug 17, 2021

Conversation

gaku-sei
Copy link
Contributor

@gaku-sei gaku-sei commented Aug 17, 2021 •
edited
Loading

This time the values should be always of type Js.Json.t

@gaku-sei gaku-sei added question Further information is requested work in progress labels Aug 17, 2021
@gaku-sei gaku-sei force-pushed the normalize-value-representation branch from 6fc9028 to 7c371f1 Compare August 17, 2021 08:31
@gaku-sei gaku-sei force-pushed the normalize-value-representation branch from 7c371f1 to 4021c48 Compare August 17, 2021 08:37
@gaku-sei gaku-sei requested review from infothien and vtrofin August 17, 2021 08:37
infothien
infothien approved these changes Aug 17, 2021
View reviewed changes
Copy link
Contributor

@infothien infothien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for your update ! Look nice to me

@gaku-sei
Copy link
Contributor Author

Thank you @infothien 😄

I'm currently updating the ATS, if there is anything weird I'll push another pr 👍

@gaku-sei gaku-sei merged commit 0677f9f into main Aug 17, 2021
@gaku-sei gaku-sei deleted the normalize-value-representation branch August 17, 2021 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infothien infothien infothien approved these changes

@vtrofin vtrofin Awaiting requested review from vtrofin

Assignees
No one assigned
Labels
question Further information is requested ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gaku-sei @infothien