Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies and use Vite #13

Merged
merged 3 commits into from
Aug 17, 2021
Merged

Update dependencies and use Vite #13

merged 3 commits into from
Aug 17, 2021

Conversation

gaku-sei
Copy link
Contributor

Vite is, well, fast and it's really a breeze to start the example now!

Notice that the yarn build command is hardly necessary now as yarn example starts a compiler in parallel.

Also, I use mjs instead of js for the compiled extensions internally but it should have no impact for the projects.

@gaku-sei gaku-sei added question Further information is requested ready for review labels Aug 17, 2021
infothien
infothien approved these changes Aug 17, 2021
View reviewed changes
Copy link
Contributor

@infothien infothien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaku-sei gaku-sei merged commit 3849034 into main Aug 17, 2021
@gaku-sei gaku-sei deleted the update-dependencies branch August 17, 2021 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infothien infothien infothien approved these changes

Assignees
No one assigned
Labels
question Further information is requested ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gaku-sei @infothien