Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use functor pattern to clean the validations #22

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use functor pattern to clean the validations #22

wants to merge 1 commit into from

Conversation

gaku-sei
Copy link
Contributor

@gaku-sei gaku-sei commented Jan 14, 2021 •
edited
Loading

No description provided.

@gaku-sei gaku-sei force-pushed the revamp-validations-array branch from 1ea2a87 to 7b2d000 Compare January 14, 2021 10:06
@gaku-sei gaku-sei added question Further information is requested ready for review labels Jan 14, 2021
@gaku-sei gaku-sei force-pushed the revamp-validations-array branch from 7b2d000 to 8afdfc1 Compare January 14, 2021 10:22
infothien
infothien approved these changes Jan 14, 2021
View reviewed changes
Copy link
Contributor

@infothien infothien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am okie with it ! Thank you Kevin-san

@gaku-sei
Copy link
Contributor Author

Thank you very much @infothien 😄

If you don't mind, I have have an alternative in mind that could solve the list/array issue without introducing a whole new logic. I will try to make a separate pr for that 👍

@infothien
Copy link
Contributor

wow that sounds even better :D. Looking forward that

@gaku-sei gaku-sei mentioned this pull request Jan 15, 2021
Merged
@gaku-sei
Copy link
Contributor Author

The alternative is here #30 😄

@gaku-sei gaku-sei closed this in #30 Jan 15, 2021
@gaku-sei gaku-sei reopened this Jan 15, 2021
@gaku-sei gaku-sei force-pushed the revamp-validations-array branch from 8afdfc1 to d309352 Compare January 15, 2021 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infothien infothien infothien approved these changes

Assignees
No one assigned
Labels
question Further information is requested work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gaku-sei @infothien